×

INDI Library v2.0.6 is Released (02 Feb 2024)

Bi-monthly release with minor bug fixes and improvements

Driver OnStep (LX200 like) for INDI

  • Posts: 65
  • Thank you received: 4
Looks like bailed out is used to describe leaving.

To bail out of a plane with a parachute you are leaving the plane.
2 years 4 months ago #78023

Please Log in or Create an account to join the conversation.

  • Posts: 161
  • Thank you received: 39
Sorry for the confusion!

To best explain my use of it, would be to return, escape, abort or stop (almost always early/generally before it's done/prematurely)

I'll note to try to avoid it in the future, because searching google I can understand your confusion! Several I didn't even think of, as a native speaker. Hopefully my explanation being a bit verbose above didn't confuse you or anyone else.
The following user(s) said Thank You: Alain Zwingelstein
2 years 4 months ago #78024

Please Log in or Create an account to join the conversation.

  • Posts: 161
  • Thank you received: 39
So in multiple day+ long tests, I see plenty of network timeouts, but 0 crashes, even while accessing it with multiple things. About 6-ish per hour at 2 second timeouts on my network.

I did go ahead and change to LOG_WARN and to return true to ReadScopeStatus. (Focusers/Rotators and such are still LOG_ERROR) so the scope doesn't go into error status.

Unless anyone sees a problem I'll see about a PR to main tonight.

NOTE: The logs will have a combination of INFO/WARN/ERROR. I mostly kept the wording the same, but I'm not sure I like it: This update aborted, will retry...  (Kept the same for easy find/replace.)
Mount will not change state due to the LOG_ERRORs. (To prevent stopping captures, sequeneces, etc.)
Mount will not disconnect.


TODO (related or discovered due to this):
Convert the Focusers & such that are in functions other than ReadScopeStatus to others.
One issue is that the scope doesn't register as disconnect when on the network, I believe this is the case with the existing network code as well. (But you were more likely to have a crash than notice that.)
LX200 adjustable timeout. This is a bit trickier than I thought needing to touch a lot more things, so I'm going to make it separately. (This is IMO better than just OnStep, and will get all the LX200 functions we use, plus it should benefit anyone using a network adapter for an lx200, TeenAstro or others.)
Alain's investigations into the rotator differences on SWS vs direct.
Park: I'm not sure I'm understanding the process right (I don't use it normally), but when I set a position it's now slewing to it.

Question: Should I raise the network timeout from 2 sec to 3 sec or higher?

I see little reason to not keep the serial at 0.1 sec, I don't see errors with it, even on the slowest platform we have. There is one edge case: serial to wifi or bluetooth to serial might be slower, but only if it's setup as a serial port, as opposed to accessing the serial port over a network. I don't have a bluetooth serial module to test right now. (and I've had horrible luck with them.) That should be resolved with the adjustable timeout patch later on.
2 years 4 months ago #78128

Please Log in or Create an account to join the conversation.

  • Posts: 452
  • Thank you received: 71
James,
No issue with the PR.
2 years 4 months ago #78132

Please Log in or Create an account to join the conversation.

  • Posts: 322
  • Thank you received: 31
James,

Thanks for looking into this in more detail, and finally solving the crashes.

Just to be clear, does the PR include only the different timeouts for network vs. serial?
Or does it also include checking the presence of the devices we know will cause timeouts if they a not there (specifically the return of :FA (focuser1), :fA (focuser2), and :GX98 (rotator)?

If the PR does not include those, then I really think these should be included.
2 years 4 months ago #78143

Please Log in or Create an account to join the conversation.

  • Posts: 452
  • Thank you received: 71
@James,

I am testing your latest PR and so far do not notice any issue.
I am running it on two OnStep configuration:
- Without any Focuser / Rotator
- With a Focuser
Even the strange jump when Parking / Unparking is not there anymore.
I will leave those running some time but it looks like you fixed it.

Thanks you very much for your work
The following user(s) said Thank You: james_lan
2 years 3 months ago #78312

Please Log in or Create an account to join the conversation.

  • Posts: 161
  • Thank you received: 39
The PR included that difference in timeouts, as well as a bunch of verification so that if there's a timeout it will warn, and abort the update.

It will probe and detect focusers and rotators, as has always been done. (Which on serial should amount to the 0.1 sec timeout, or 2 sec on network.) So yes, those will cause timeouts on startup.

I did add a little gating based on version to something with rotators. Up to V3 lacks the commands. rI rM rT and has no equivilent (at least in the current version and prior versions I looked at.) That and checking for OnStepX focusers (when version is OnStepX or unknown) are the only gating like that. As for the most part the commands are pretty consistent across versions.
2 years 3 months ago #78348

Please Log in or Create an account to join the conversation.

  • Posts: 452
  • Thank you received: 71
@James,
till no issues after one night running of two instances of OnStep on Kstars.

How did you set-up your testing environment?
I am using QTCreator to run OnStep in Debug mode, not allways easy on a single screen machine but helps a lot.
2 years 3 months ago #78353

Please Log in or Create an account to join the conversation.

  • Posts: 322
  • Thank you received: 31
Jasem merged the PR from James.

So I updated from Jasem's repo, then compiled it and testing now over WiFi.
There are no timeouts.

One very important and confusing change: there is no way to change the connection at all since all the fields are missing now.

Here is a screenshot to better show what the issue actually is.
 
2 years 3 months ago #78364

Please Log in or Create an account to join the conversation.

  • Posts: 452
  • Thank you received: 71
Khalid,

unfortunately this missing fields are not OnStep related. Did you try again after restarting Kstars.
I observe the same using Eqmod.
And it is not reproducible, sometimes yes sometimes no ...
2 years 3 months ago #78366

Please Log in or Create an account to join the conversation.

  • Posts: 322
  • Thank you received: 31
Yes, now that I tried a couple of times, the connection info is shown and can be changed.

I guess we need to report this to Jasem, so it is fixed before the next packages are built. Right?
2 years 3 months ago #78369

Please Log in or Create an account to join the conversation.

  • Posts: 452
  • Thank you received: 71
I suppose yes.
I noticed this some time before .
The strange thing is I cannot find a rule to reproduce it.
2 years 3 months ago #78371

Please Log in or Create an account to join the conversation.

Time to create page: 1.252 seconds