×

INDI Library v2.0.6 is Released (02 Feb 2024)

Bi-monthly release with minor bug fixes and improvements

Re:Polar Alignment cause Ekos to crash

  • Posts: 319
  • Thank you received: 25
Just to confirm that using the “limited resource mode” is working as workaround till this problem is fixed.

@Hy
I didn’t have to change the code to avoid this method/function.

@Jasem
Sure I can send you the images set you requested (and I will), but remember that I tried to replicate the problem using Ubuntu and even another raspberry pi connected to the same hardware via Indi as a server and I was not able to replicate the problem.

The only way I was able to replicate the problem was through raspberry pi working as dev device doing remote deployment and debugging on the rig itself.
Last edit: 2 years 5 months ago by Mohamed.
2 years 5 months ago #76114

Please Log in or Create an account to join the conversation.

  • Posts: 1208
  • Thank you received: 559
Mohamed,

Would you be willing to test out a shot-in-the-dark fix for me?
Obviously, when you test this, disable limited-resources-mode, so that it would normally crash after your 3rd iteration.

You would need to clone my fork of my KStars repo and test with a new branch (called wcs-fix1) from the current HEAD in that  codebase:
  cd SOME_NEW_PLACE_TO_PUT_A_TEMPORARY_KSTARS
  git clone  invent.kde.org/murveit/kstars.git
  cd kstars
  git checkout wcs-fix1
and then compile that KStars tree I suppose the same way you've set up other compiles, and execute the binary you compile, and run your test.
This has a few small changes to fitsdata.cpp, fitsview.cpp, fitsview.h which you could see by using git difftool.

It it works, of course great and let me know. If not, please send along a log with at least FITS debugging enabled.

Thanks,
Hy

 
2 years 5 months ago #76136

Please Log in or Create an account to join the conversation.

  • Posts: 319
  • Thank you received: 25
@Hy

I did and it crashed again. Below are the log files

 

File Attachment:

File Name: log_22-14-00.txt
File Size:380 KB


 

File Attachment:

File Name: kstars_deb...4-00.txt
File Size:5 KB
2 years 5 months ago #76144
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 1208
  • Thank you received: 559
Mohamed,

I pushed another check in there.  Can you please try again?

Go to the same fork and git pull, then compile and test as before.
You should see 2 new commits. 

Thanks
Hy

commit ea46ab2e40781557aa4a6fa034111ef534218a97 (HEAD -> wcs-fix1, origin/wcs-fix1)
Date:   Wed Sep 29 23:09:51 2021 -0700

    refactor the min/max checks

commit 032c53edb1eee7621377ea4bba585bd8b1ae5e81
Date:   Wed Sep 29 22:52:53 2021 -0700

    Check for null inside of the min/max loop



 
Last edit: 2 years 5 months ago by Hy Murveit.
2 years 5 months ago #76149

Please Log in or Create an account to join the conversation.

  • Posts: 319
  • Thank you received: 25
@Hy

Crashed again. PFA logs

 

File Attachment:

File Name: kstars_deb...2-16.txt
File Size:6 KB


 

File Attachment:

File Name: log_19-52-16.txt
File Size:3,642 KB
2 years 5 months ago #76182
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 1208
  • Thank you received: 559
Mohamed,

I really appreciate your efforts. I'm pretty much out of ideas. However, just in case, I simplified the code, and added a bunch more logging in one more commit.
If you have the patience, please try to git pull again from my wcs-fix1 branch in my fork and send me the logs (assuming it fails).

Hy

commit 3ef6b2f0e8e7a59acc3353b2d40568dd49813820 (HEAD -> wcs-fix1, origin/wcs-fix1)
Date:   Thu Sep 30 19:26:52 2021 -0700

    simplify--remove lambda
 
Last edit: 2 years 5 months ago by Hy Murveit.
2 years 5 months ago #76191

Please Log in or Create an account to join the conversation.

  • Posts: 319
  • Thank you received: 25
Sure Hy, I'm glad to help. I shall test the new code tomorrow. BTW, I really appreciate your PAA. It is the best tool I used till today to perform precise and easy PA.

I Will get back to you tomorrow evening (weather permitting)...
2 years 5 months ago #76193

Please Log in or Create an account to join the conversation.

  • Posts: 319
  • Thank you received: 25
Sorry Hy, It crashed again, PFA

I shall start a remote debugging session and will play around with the code and see what I can find or do. Will keep you posted

 

File Attachment:

File Name: kstars_deb...1-24.txt
File Size:6 KB


 

File Attachment:

File Name: log_21-21-24.txt
File Size:1,776 KB


 
2 years 5 months ago #76239
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 1208
  • Thank you received: 559
Oh well, at least your polar alignment is good ;)

Can you get the simulator to crash while polar aligning it?

If so, send instructions on how to reproduce.

Of course, we have that workaround, turning on limited resources mode, which stops the crashes by stopping the equatorial graphics.

Hy
2 years 5 months ago #76240

Please Log in or Create an account to join the conversation.

  • Posts: 1208
  • Thank you received: 559
Mohamed,

If you're going to try and chase down the issue, here's one thing you can try. The only change I can think of related to polar alignment in the last several months is this.Jasem moved all the code into its own file. If you want, check out the version of KStars right before Jasem made that change and see if things were better before that change.

In the main KStars tree:

git checkout faa28833

This should put you right before his change, about a month ago. You could try to compile and test that without limited resources mode and see if things were working back then. In general you can use git checkout to go back to arbitrary commits in the codebase.

To go back to the present just

git checkout master

Hy
2 years 5 months ago #76241

Please Log in or Create an account to join the conversation.

  • Posts: 319
  • Thank you received: 25
Hello Hy

I tried to simulate the crash using simulation but didn’t crash. If the sky was ok tonight I shall try the rollback you suggested and will keep you posted…
2 years 5 months ago #76255

Please Log in or Create an account to join the conversation.

  • Posts: 16
  • Thank you received: 1
hi,
any updates on this please? will i be safe to upgrade software. at the moment reverted back to stellarmate v1.5.9 where the polar alignment routine works fine. but having just bought a new scope (hence the cloud and rain here now) and adjusting my rig shall i stick with 1.5.9 or how do i enable this limited resource mode workaround. i have v1.5.9 and and 1.6.0 on different sd cards so backups but with said weather here not had chance to test polar alignment routine.
thanks in advance and for all the effort everyone puts in here.
2 years 5 months ago #76770

Please Log in or Create an account to join the conversation.

Time to create page: 0.583 seconds