×

INDI Library v2.0.6 is Released (02 Feb 2024)

Bi-monthly release with minor bug fixes and improvements

myFocuserPro or myFocuserPro2 and INDI

  • Posts: 77
  • Thank you received: 14
As stated many times before, I have never worked in git as a developer, and I am by no means a linux guru, so your previous comment really doesn't help me get any closer to a solution. My biggest concern is that I will loose my changes, by not really understanding what is going on, I also understand you are a very busy man, and don't have time to answer these sort of requests. Unfortunately I too am busy, and can't commit the time to learning git at this moment in time. Maybe we need a developer git help forum? I guess my problem was I didn't do a "git fetch" before starting my edits at lunch time?

After a bit of googling, I think I am back to some sort of synchronisation. You said "if I can create a PR....", I believe I already had, with a commit from myself, then one from you and now another from me just now. I manually opened the problem file with "nano" (horrible text editor) and then checked line by line looking for merge messages (there must be a better way of doing this?)

Anyway, I have done a commit. and my end says it is up to date, so I assume somehow I have muddled through and pushed my changes?
4 years 5 months ago #44388
The topic has been locked.
Pretty much all developers hate GIT when they start working with it, then slowly comes in terms with its power. So everything is sorted out, thanks. Can you double check the code, is everything there?
4 years 5 months ago #44430
The topic has been locked.
  • Posts: 29
  • Thank you received: 6
Hi everyone,

This is my first post.
I read carefully most of the threads on this forum since few months. In fact since I installed a RPi3b+, running Stellarmate as server for my astronomy equipment. I learn a lot and most of the time, I find answers to my questions. thanks to all for that.
I just received a "myFocuser Pro2" from Robert Brown in New Zeeland and I would like to test it, first via Kstars/Indi device manager and then, directly via ekos.
My problem is that I do not find the driver in the list of the focusers, even after having updated Indi... Probably I missed something :(

Thanks for your help,

Pierre-Yves
4 years 5 months ago #44431
The topic has been locked.
Hello Pierre-Yves,

Welcome to INDI forum. The focuser is not yet available in the stable release. It should be within a couple of weeks with the next stable release of INDI.
4 years 5 months ago #44443
The topic has been locked.
  • Posts: 29
  • Thank you received: 6
Ok Jasem, thanks for your feedback. I was misled by the indi web page regarding this focuser that suggests that the driver is available.
Pierre-Yves
4 years 5 months ago #44444
The topic has been locked.
It is available in the INDI Nightly Builds.

The documentation says it is available INDI Library >= v1.8.2

Current stable INDI version is v1.8.1
Last edit: 4 years 5 months ago by Jasem Mutlaq.
4 years 5 months ago #44447
The topic has been locked.
  • Posts: 29
  • Thank you received: 6
Sorry, I did'nt pay attention to the Indi release numbering.
Thanks Jasem.
4 years 5 months ago #44448
The topic has been locked.
  • Posts: 77
  • Thank you received: 14
I've double checked the code and it looks like everything is as intended. Tested too!
The following user(s) said Thank You: Acapulco Rolf
4 years 5 months ago #44521
The topic has been locked.
  • Posts: 52
  • Thank you received: 15
Thanks Alan

About to run some sanity test on the latest MyFP2 indi driver build (version 3) against the v2.91 focuser firmware

Before I run any tests, I took a quick look at the MyFP2 indi driver source code on git

You mentioned that:

" I will then make the base firmware check equal to or greater than 291."

It looks like the minimum firmware version check is as follows:



Is this as intended?
4 years 5 months ago #44533
Attachments:
The topic has been locked.
  • Posts: 52
  • Thank you received: 15
Ah, I see the issue now

The commit for myfocuserpro2.h on your git fork
github.com/ajt68/indi/tree/master/drivers/focuser

is ahead of the commit on
github.com/indilib/indi/tree/master/drivers/focuser
4 years 5 months ago #44534
The topic has been locked.
  • Posts: 77
  • Thank you received: 14
OK lets regroup, my last commit is not what was intended!!!

I did a merge and believed I made the correct changes, then committed and did a pull, at which time I was told I was up to date. So I assumed because my changes were correct at my end, then that is what was committed.

I have just realised this is not the case, and the only change was the version number!!!??? This was discovered whilst setting up an AstroBerry, and pulling the latest nightly, I noticed my changes were not there.

So I have two file on my development end, that need to be committed via a pull request?
I guess the steps are
1. Create a commit (should I do some sort of sync first, and if so what should I do?).
2. Create a Pull Request at the head end, and associate the above commit?

I won't do anything until I get some feedback, as this is how I started getting in this mess, and can't understand why only the version number was committed?

TIA.
Last edit: 4 years 5 months ago by Alan Townshend.
4 years 5 months ago #44544
The topic has been locked.
  • Posts: 77
  • Thank you received: 14
So no feedback on what to do so I have just tried another commit and pull request and again a conflict, but I think I have now pushed/pulled the code I intended (version 0.4)
The following user(s) said Thank You: Acapulco Rolf
4 years 5 months ago #44652
The topic has been locked.
Time to create page: 0.687 seconds