After running your script again to install these new WiFi upgrades, I just opened Kstars and it’s broken, it opens, then when I click ekos it brings up a window that says:

“An instance of INdI server is already open, do you want to close before opening another”

and no matter if I click yes or no it just shuts Kstars completely down every time...
Any ideas..

It is possible there was a change in KStars. My script wouldn’t change it, but it does install the latest KStars

Are you running another INDI server such as with INDI Web Manager App, INDI web manager, or as a service?

You can always try quitting those. Or from the command line killall indiserver

No, not running any other...and have made sure, but error still comes up, also have run update on older pi3 and Kstars is fine..so not sure, but was fine before I ran the script again..

Did you try

killall indiserver?

Yep, no other running..

I get no IP address when I connect the Pi to my desktop. How do I set up the network manager to automatically connect to the LAN?

Ok I solved it. I had to remove the ethernet configuration from the network manager. It then automatically connected to my PC and assigned it an IP address in the correct range.
I re-ran the script and used that IP address. All is well now.

I'm not sure I understand. You are connecting the PI to your desktop or laptop computer with an ethernet cable? Are you away from the network in a field, or are you trying to connect it to your router with ethernet? I'm not sure what you are trying to do here.

In my script, I set it up to respond to a plugged in Ethernet cable by doing 2 things. 1. Connect to your LAN and get an IP address via DHCP if you plug in an ethernet cable connected to your router. This "Connection" is called Wired DHCP Ethernet and it tries that first. 2. If the first one fails, to switch to a network with a static IP address for connecting directly to a laptop when there is no internet in the middle of an observing field. That is the "Link Local" connection.

I will try rebuilding kstars on my pi and see if I get the same error.

I think you might as a few people have up to yet, nothing to do with your script I might add..

No the error doesn’t have anything to do with my script but if there is some sort of KStars error, and it is revealed this way, we should see what it is.

RLANCASTE:
I have resolved it, see edited comment above. But so you understand. No, I do not use a PC in the field. I have a portable display and keyboard directly connected to the Pi.
At home though, when I am setting things up and messing around on the Pi I like to use VNC connection to the pi from my PC via an ethernet cable connected to one of the 2 network ports my desktop has. So it doesn't even go through my home network router, but the internet is shared through the PC.
I think my issue was that the first time I ran the script I stated Yes to making a static IP, but then wasn't sure when to enter at the time. So I continued without entering the any IP. It seemed to recognise it was invalid and moved on with the process.
It did create the 'Wired DHCP Ethernet' connection, but not the second Link Local Ethernet when I did that.

Clever bloke like you might, but I ain’t gotta clue what I’m looking for..