They were done at different times of day. But the instability was resolved after getting around to recompiling the test application. But you are saying that it should not have had an effect. Odd.

In any case. it doesn't appear there is anything to fix. But I thought it might be important to report as it is a possible cause for crashes other's might encounter while testing.

Hey Jim,

I just pushed a possible fix for your build issue. Please see if it fixes the problem. If not, I will see what Jasem says.

Thanks,

Rob

Thanks Rob, I confirmed it was fixed yesterday, but failed to make it back here to let you know. Thanks!

Jim

Good to hear, thanks!!

Folks. Now I can say all the pieces are in place. I told Robert that I noticed a higher rate of failure using the internal solver than the prior astrometry.net, so let's start investigating all possible issues for such error. It's either in the extraction part or the solving part.

In addition to the StellarSolver changes, I also pushed a major update to the FITS Viewer which can now handle RAW files as well as jpg/pngs (added by Robert previously). So no need to open extra windows, all be handled within the FITS Viewer. Furthermore, lots of temporary files were used before between different kinds of operations. This is completely gone now, and we use buffers in RAM all the way to speed up everything. Finally, the same data can be shared between multiple views so now the Summary view will not longer consume more RAM when enabled since it uses the same data. It's not perfect yet since implicit data sharing is not yet truly complete but it's a start.

Rob, Jasem, contributers, and testers,

The amount of work and features going into this release is amazing. Thank you all very much.

Jim

I echo Jim's accolades! This will be great, but at the moment I am hitting a snag again when compiling from source:

[ 34%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/indielement.cpp.o
[ 34%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/indistd.cpp.o
[ 34%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/indilistener.cpp.o
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indidevice.cpp:39:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indidevice.cpp:39:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/starprofileviewer.h:15,
from /home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsview.h:19,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.h:16,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indilistener.cpp:17:
/home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsdata.h: In member function ‘int FITSData::channels() const’:
/home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsdata.h:162:33: error: ‘const struct FITSImage::Statistic’ has no member named ‘channels’
162 | return m_Statistics.channels;
| ^~~~~~~~
[ 34%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/inditelescope.cpp.o
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiproperty.cpp:17:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiproperty.cpp:17:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
[ 35%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/indiccd.cpp.o
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indistd.cpp:21:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indistd.cpp:21:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
[ 35%] Building CXX object kstars/CMakeFiles/KStarsLib.dir/indi/wsmedia.cpp.o
make[3]: *** [kstars/CMakeFiles/KStarsLib.dir/build.make:785: kstars/CMakeFiles/KStarsLib.dir/KStarsLib_autogen/mocs_compilation.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indilistener.cpp:25:
/usr/include/libstellarsolver/parameters.h: At global scope:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indilistener.cpp:25:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
make[3]: *** [kstars/CMakeFiles/KStarsLib.dir/build.make:954: kstars/CMakeFiles/KStarsLib.dir/indi/indilistener.cpp.o] Error 1
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/starprofileviewer.h:15,
from /home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsview.h:19,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.h:16,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.cpp:10:
/home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsdata.h: In member function ‘int FITSData::channels() const’:
/home/ubuntu/Projects/kstars/kstars/kstars/fitsviewer/fitsdata.h:162:33: error: ‘const struct FITSImage::Statistic’ has no member named ‘channels’
162 | return m_Statistics.channels;
| ^~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/inditelescope.cpp:17:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/inditelescope.cpp:17:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
/home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.cpp: At global scope:
/home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.cpp:106:6: warning: ‘bool {anonymous}::writeTempImageFile(const QString&, char*, size_t, QString*)’ defined but not used [-Wunused-function]
106 | bool writeTempImageFile(const QString &format, char * buffer, size_t size, QString *filename)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.cpp:22:
/usr/include/libstellarsolver/parameters.h:211:16: warning: ‘QString SSolver::getLogLevelString(SSolver::logging_level)’ defined but not used [-Wunused-function]
211 | static QString getLogLevelString(SSolver::logging_level logLevel)
| ^~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:170:16: warning: ‘QString SSolver::getMultiAlgoString(SSolver::MultiAlgo)’ defined but not used [-Wunused-function]
170 | static QString getMultiAlgoString(SSolver::MultiAlgo multi)
| ^~~~~~~~~~~~~~~~~~
In file included from /home/ubuntu/Projects/kstars/kstars/kstars/auxiliary/ksutils.h:36,
from /home/ubuntu/Projects/kstars/build/kstars/Options.h:12,
from /home/ubuntu/Projects/kstars/kstars/kstars/indi/indiccd.cpp:22:
/usr/include/libstellarsolver/parameters.h:101:16: warning: ‘QString SSolver::getCommandString(SSolver::ProcessType, SSolver::ExtractorType, SSolver::SolverType)’ defined but not used [-Wunused-function]
101 | static QString getCommandString(SSolver::ProcessType processType, SSolver::ExtractorType m_ExtractorType,
| ^~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:60:16: warning: ‘QString SSolver::getScaleUnitString(SSolver::ScaleUnits)’ defined but not used [-Wunused-function]
60 | static QString getScaleUnitString(SSolver::ScaleUnits scaleunit)
| ^~~~~~~~~~~~~~~~~~
/usr/include/libstellarsolver/parameters.h:18:16: warning: ‘QString SSolver::getShapeString(SSolver::Shape)’ defined but not used [-Wunused-function]
18 | static QString getShapeString(SSolver::Shape shape)
| ^~~~~~~~~~~~~~
make[3]: *** [kstars/CMakeFiles/KStarsLib.dir/build.make:980: kstars/CMakeFiles/KStarsLib.dir/indi/indiccd.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:1354: kstars/CMakeFiles/KStarsLib.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:1332: kstars/CMakeFiles/kstars.dir/rule] Error 2
make: *** [Makefile:500: kstars] Error 2



This is with Stellar Solver installed fresh and with a pristine new git pull of kstars also as of this morning. I tried to compile it 3 times, it always hangs at the same place.
Should I just wait for the next Stellar Solver update or is there another way to fix this?

Jo

Make sure stellarsolver is indeed installed properly as this was fixed yesterday.

If the Stellar Solver Tester works, it should be properly installed, right? See the build date on top.

The stellarsolver 'issues' are only warnings about unused stuff, the error is from the fits viewer:

Not sure what's wrong though - compiled w/o errors here.

Can only test it with the simulator, and it has problems solving those, maybe because of the small field? Two of my load&slew objects (Cocoon, Helix) loaded&solved fast.

Somewhat nasty: If the solver fails on the captured frame, the 'load&slew' button stays disabled until I do another slew...

Odd. I deleted my kstars and build folder, then recompiled Stellar Solver (only compiled and installed a few hours ago) and reinstalled it again. Then recompiled kstars from source. Now it installed fine.

Looks like the Stellar Solver was out of date by a couple of hours and that's why the kstars build failed?

You can solve any fits image you have acquired in the past, using the simulator in the solver and the 'Load and Slew' option to see if it in fact slews to the correct position. Works fine at my end.