I am finishing up a driver for the nFrame and at the testing of Preset GoTo's.
Is there any flag that is set when Move is called to indicate the GoTo is from a Preset ?
I.e. "PresetGotoSP.s == IPS_BUSY"

In indirotatorproperties.cpp I see for a normal GoTo
            GotoRotatorNP.s = MoveRotator(values[0]);
            Now in MoveRotator there is a 'return IPS_BUSY'
            And in TImerHit there is a check to see if GoToRotatorNP.s is IPS_BUSY indicating a Move should happen

But for Preset I see this in indirotator.cpp
            if (MoveRotator(PresetN[index].value) != IPS_ALERT)
            {
                PresetGotoSP.s = IPS_OK;

So it totally ignores any response other than IPS_ALERT and sets 'IPS_OK'

Thoughts on -what- a rotator driver should use considering the non-symmetry of the interface to 'MoveRotator' ?

Thanks!

Gene

Thank you Gene, that's another very good catch. It was indeed missing changing GotoRotatorNP to busy. I just pushed a fix to this, please check it out.

Hi Jasem,

Thanks! Looks good.
I went through the drivers/rotator/*.cpp files and looks like the pyxis.cpp would have the same issue as Preset's would not 'GoTo' ?

Gene