×

INDI Library v2.0.7 is Released (01 Apr 2024)

Bi-monthly release with minor bug fixes and improvements

"Captures" in Windows EKOS Scheduler does not count up.

  • Posts: 179
  • Thank you received: 25
I fixed it and attach a git diff file.
See the attached "git diff" file for details.

How to fix it
The directory separator in "Signature" is now a slash in KStars for Windows as it is in Linux.
This will correctly separate directory and file names containing regular expressions from "Signature".

Change-1)
File: kstars/kstars/ekos/capture/placeholderpath.cpp
Menber function: QString PlaceholderPath::generateFilename(const QString &directory,
const QString &format,
uint formatSuffix,
const QString &targetName,
const bool isDarkFlat,
const QString &filter,
const CCDFrameType &frameType,
const double exposure,
const bool batch_mode,
const int nextSequenceID,
const QString &extension,
const QString &filename,
const bool glob,
const bool gettingSignature) const

Added the following processing, effective only if Q_OS_WIN is defined
  • Replace the directory separator Backslash with Slash before the Place Holder is set.

Change-2)
File: kstars/kstars/ekos/scheduler/scheduler.cpp
Member function: int Scheduler::getCompletedFiles(const QString &path)

Added the following processing, effective only if Q_OS_WIN is defined.
  • The directory separator of the argument "path" given from "Signature" by Change-1 is "slash".
  • The process to assign directory to sig_dir and basename to sig_file was added using "slash" as the directory separator.
  • However, on Windows, QFileInfo includes a process to convert a backslash to a slash and cannot correctly split a path into a directory and a basename, so a process to split a path into a directory and a basename without using QFileInfo was added.
8 months 1 week ago #94776
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
I forgot to write one thing.
I modified it based on the "stable-3.6.6" source code.
Last edit: 8 months 1 week ago by tkakura.
8 months 1 week ago #94778

Please Log in or Create an account to join the conversation.

Can you please share your full name so I can commit to code to KStars?
8 months 1 week ago #94788

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
I sent messege to you about my name.
Thanks.
8 months 1 week ago #94791

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
Hi Jasem

Kstars 3.6.7 for Windows seems to reproduce this problem.
The Build is 2023-10-04T13:19:08Z.

It is counted up in the Capture Module but not in the Scheduler.
You can see it in the two screenshots with almost the same timing.

5 months 2 weeks ago #97135
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
Hi Jasem

I investigated the cause with the debugger.
The problem is reproduced when "%P" is added to the file name format.

In the reproduced pattern, "%P" is replaced by "Unknown" in the argument "path" of Scheduler::getCompleteFile.
However, since the Captured file name has "East" appended to it, the file name does not match at Line 6565.
This is true even if the Captured filename contains "West".



Shouldn't the placeholder "%P" be a regular expression that matches (Unknown|East|West)?
Last edit: 5 months 1 week ago by tkakura.
5 months 1 week ago #97157
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
P.S. "%C" doesn't match either.
5 months 1 week ago #97159

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
This ISSUE is also reproduced when %G and %O are specified and values are set for Gain and Offset in the Capture Module.

5 months 1 week ago #97173
Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 1187
  • Thank you received: 370
Problem confirmed, folks. Thank you for reporting.

Could you please take a look at MR!1045 ? It should hopefully fix the reported problem for gain, offset, pier side and temperature.

Feedback warmly welcome.
Wolfgang
5 months 1 week ago #97247

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
Hi Wolfgang
Thank you for the fix it.

Can I download the fixed version of the executable from the following web page?
kstars.kde.org/ja/download/
5 months 1 week ago #97259

Please Log in or Create an account to join the conversation.

  • Posts: 1187
  • Thank you received: 370
Not yet the fix just made it into the master source. The next release is planned for December 1st.

If you want to test it earlier, you need to build KStars from sources as described here: invent.kde.org/education/kstars#development
5 months 1 week ago #97264

Please Log in or Create an account to join the conversation.

  • Posts: 179
  • Thank you received: 25
Hi Wolfgang

The following regular expression would match different patterns.
Line 374
                replacement = "(East)|(West)|(Unknown)";

The following regular expression is better.
                replacement = "(East|West|Unknown)";

This is about when the following formats are specified in the capture module
Stars_g%G_p%P

The committed code will generate the following Placeholder
Stars_g\\d+_p(East)|(West)|(Unknown)
This means "Stars_g\\d+_pEast", "West" or "Unknown".

The following figure shows an example of confirming the behavior with "grep -P".
There is a red text match and the file name is considered a match.


In this example, "(East)|(West)|(Unknown)" would also match Westan_Nebula and West.
5 months 1 week ago #97267
Attachments:

Please Log in or Create an account to join the conversation.

Time to create page: 1.106 seconds