Frank Chen created a new topic ' The manner of pull-request' in the forum. 12 months ago

Hello,
I have some bug fixes for my 3rdparty focuser driver. I will commit them and then create pull-requests. I have read some notes about the pull-request on github.com/indilib/indi-3rdparty. But I still have some questions about the manner of pull-request.

Some of the bug fixes are quite simple. The modifications for each bug-fixing may be just one line of code. But those bug fixes are different in logic. Shall I merge the bug fixes in one PR, or separate them in different PRs?

I think the bug fixes in separate PR is better for code maintaining and tracking, but we shouldn't produce too many PRs to make INDI maintainers heavy loaded. So could you please let me know the proper ways for creating PRs?

Thanks!

Read More...