×
INDI Library v1.8.5 Released (19 Apr 2020)

April 2020 release of INDI Library v1.8.5 introduces new drivers while providing fixes and improvements to existing devices and core framework.

Mosaic tool - overlap not correct on width

4 weeks 1 day ago
BigNoel
Junior Boarder
Junior Boarder
Posts: 30
Karma: 1
More
Topic Author
Mosaic tool - overlap not correct on width #56734
Hi all,

I'm using INDI Library 1.8.5 ; Kstars 3.4.2 ; Source: PPA ; Kernel/Arch : 5.4.0-40-generic #44-Ubuntu SMP Tue Jun 23 00:01:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux.

My mosaics that are 1W x 2H have correct overlap, however my 2W x 1H have more overlap - about 30% instead of 5%.
The maths seems to check out OK when looking at the calculated RA/DEC for the panels, but there is a big overlap for some reason.

This can be recreated using the simulator CCD.
I created an example using NGC5139, simulator CCD (1280x1024, 5.2um pixel) with a 480mm FL scope. FOV is 47.67' x 38.14'.
For the example I set a 2Wx1H mosaic with zero overlap, I expect difference between the panels to be 47.67', the width of the FOV.
The tool created 2 jobs:
(1) RA 13h 28m 20.77s DEC -47° 28" 39.59'
(2) RA 13h 25m 10.09s DEC -47° 28" 39.59'
The difference in RA is 3m 10.68s which is 47.67 arcmin, which is what I expected.
There is no difference in DEC, also as expected.

However, in real world use with my Canon DSLR and also evident here using the simulator CCD dimensions and viewing the RA/DEC for each panel in Stellarium, there is a big overlap between panels.




My maths may be wrong - I certainly not an expert at this, I initially thought it was a bug with the tool but I'm scratching my head as to why the panels overlap so much. As mentioned earlier, this only affects panels along the width of the mosaic, not its height.

Cheers,
Noel.
Attachments:

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
BigNoel
Junior Boarder
Junior Boarder
Posts: 30
Karma: 1
More
Topic Author
Mosaic tool - overlap not correct on width #56737
Some more info:
I tested this with the simulator creating a 2x2 mosaic.
The problem also is evident here too. I've also had the same issue in real world use with bigger mosaics like this.

Mosaic tool settings:


Simulating CCD view in Stellarium using the RA/DEC from the mosaic jobs, there is a 30% overlap on horizontal panels when there should be no overlap. Vertical panels are correct.
Attachments:

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
BigNoel
Junior Boarder
Junior Boarder
Posts: 30
Karma: 1
More
Topic Author
Mosaic tool - overlap not correct on width #56739
I calculated the same 2Wx1H mosaic of NGC5139 layout using Telescopius. Interestingly it generated :
Pane, RA, DEC, Position Angle (East)
PANE 1, 13hr 29' 07", -47º 28' 46", 0
PANE 2, 13hr 24' 27", -47º 28' 46", 0

These are 4' 40" apart in RA. Compared to 3' 10.7" apart from the Ekos tool. The Telescopius panels line up correctly when checked in Stellarium.

As the DEC calculations are OK, I wonder if the issue relates to the difference in units used between RA and DEC - maybe the code behind the tool is treating these the same where they should be different?
The following user(s) said Thank You knro

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
knro
Administrator
Administrator
Posts: 8205
Karma: 51
Mosaic tool - overlap not correct on width #56741
Thank you for the detail investigation. This indeed appears to be a bug but I didn't have enough time to investigate it. Maybe you can spot the issue here ? This is where it's calculating the center points for each mosaic panel.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
BigNoel
Junior Boarder
Junior Boarder
Posts: 30
Karma: 1
More
Topic Author
Mosaic tool - overlap not correct on width #56748
Cheers knro.

My maths or coding isn't good enough for this sorry. I did manage to recreate the calculations in Excel using the method from mosaic.cpp and found I got the wrong RA value as well.
I can say adding the width of the sensor, minus overlap (in degrees) to the RA position (degrees) gives the wrong position, though this method works for DEC.

I had a look at how Telescopius do their mosaic tool (( pastbin ) and they do some spherical and cartesian coordinate conversion - perhaps that's a hint for you.

I'll keep giving it some thought, and hopefully someone can assist.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago 4 weeks 1 day ago by jws_indi.
jws_indi
Senior Boarder
Senior Boarder
Posts: 52
More
Mosaic tool - overlap not correct on width #56750

knro wrote: Thank you for the detail investigation. This indeed appears to be a bug but I didn't have enough time to investigate it. Maybe you can spot the issue here ? This is where it's calculating the center points for each mosaic panel.


I do not understand or maybe I am missing something but why is the RA divided by 15 and the DEC not?


tile->skyCenter.setRA0( (center.ra0().Degrees() + (diffFromSkyMapCenter.x() / (pixelsPerArcmin * 60.0))) / 15.0);
tile->skyCenter.setDec0( center.dec0().Degrees() + (diffFromSkyMapCenter.y() / (pixelsPerArcmin * 60.0)));

The only other reference in code when I looked for diffFromSkyMapCenter was in the comments:

" QPointF diffFromSkyMapCenter = skymapCenterPoint - mosaicCenterPoint "

I understand how its calculated, this is why I don't understand why one is divided by 15 and the other is not. My math for RA and DEC along with rotation isn't allowing me to 'get' the divided by 15.

If it is beyond me disregard this post as my math skills being weak, just curious at this point :)

Cheers
Jim

Celestron CGX, QSI683 Astrodon Gen 2 E series LRGB, Ha, OIII, ES102CF, ZWO-ASI178MC, 60mm guide scope, Pegasus Focus Cube 2, Feather Touch Focuser.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
knro
Administrator
Administrator
Posts: 8205
Karma: 51
Mosaic tool - overlap not correct on width #56751
RA is in hours, but yeah it's more likely to do with spherical trig. The calculation in Mosaic assumes a flat plane which is only approximate for very small angles and breaks down over large areas. Will have to look at it more in the future unless someone wants to step it to fix that.

Jasem Mutlaq
Support INDI & Ekos; Get StellarMate Astrophotography Gadget.
How to Submit Logs when you have problems?
Add your observatory info
The following user(s) said Thank You jws_indi

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago 4 weeks 1 day ago by dmsummers.
dmsummers
Gold Boarder
Gold Boarder
Posts: 219
Karma: 2
More
Mosaic tool - overlap not correct on width #56753
I haven't yet used the mosaic tool (but soon will). Big Noel, I'm curious whether you've tried to mosaic at the celestial equator (Dec=0). Is the answer correct at Dec=0? If so, could this be a simple issue with not correctly factoring cos(dec) in the RA calc? The error for NGC5139 is suspicious in this regard.... Just a thought.

RASA11, Celestron CGX-L, ASI183mc Pro, 60mm guider + ASI290mm mini, ASI EAF focuser, PPB, Rpi4-4Gb+SSD, Powered USB3 hub, hardwire Ethernet.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago 4 weeks 1 day ago by jws_indi.
jws_indi
Senior Boarder
Senior Boarder
Posts: 52
More
Mosaic tool - overlap not correct on width #56754

knro wrote: RA is in hours, but yeah it's more likely to do with spherical trig. The calculation in Mosaic assumes a flat plane which is only approximate for very small angles and breaks down over large areas. Will have to look at it more in the future unless someone wants to step it to fix that.


Okay that makes sense. In a flat plane I would assume that each quadrant would have a value in relation to the one above, below, left, and right. On a four panel mosaic this would work out:

top left: Position lower, move to right.
top right: Position lower, move left.
bottom left: Position higher, move to right.
bottom right: Position higher, move to left.

Anything beyond 4 panels is way over my head...

Now to try and wrap my head around this with RA and DEC numbers. Thank you Jasem for the explanation, I now see that to change hours to degrees the calculation is one hour equals 15 degrees.

Cheers
Jim

Celestron CGX, QSI683 Astrodon Gen 2 E series LRGB, Ha, OIII, ES102CF, ZWO-ASI178MC, 60mm guide scope, Pegasus Focus Cube 2, Feather Touch Focuser.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
BigNoel
Junior Boarder
Junior Boarder
Posts: 30
Karma: 1
More
Topic Author
Mosaic tool - overlap not correct on width #56757
Good test dmsummers and you might be on to something.
I'll test Kstars more tomorrow night, but knowing the EKOS tool gives a 3' 10" difference in RA using the simulator when using NGC5139 as a test (DEC -47 28 36). I compared that to the Telescopius results, at RA 0, DEC 0, the difference in RA between centers of a 2x1 mosaic using the SimulatorCCD specs is... 3' 10" !
I entered a different target in Telescopius; RA 0, DEC 45. The difference in centers is 4' 28" . Clearly the Telescopius algorithm is factoring in something relating to the DEC. This might be enough for someone to solve the issue.

When it works, the mosaic tool and scheduler is magic, I really hope to see this issue fixed so I can use it more! AstroPixelProcessor does a good job at compiling the mosaic too.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
jws_indi
Senior Boarder
Senior Boarder
Posts: 52
More
Mosaic tool - overlap not correct on width #56758
Big Noel and dmsummers

It appears that within Telscopius they use +- 90, +- 180, +- 270 to achieve the overlap. The math is beyond my understanding when 'cos' and 'sin' is involved.

Gonna remove myself from this conversation while I still have a single brain cell left...

Cheers
Jim

Celestron CGX, QSI683 Astrodon Gen 2 E series LRGB, Ha, OIII, ES102CF, ZWO-ASI178MC, 60mm guide scope, Pegasus Focus Cube 2, Feather Touch Focuser.

Please Log in or Create an account to join the conversation.

4 weeks 1 day ago
Ihoujin
Platinum Boarder
Platinum Boarder
Posts: 904
Karma: 3
More
Mosaic tool - overlap not correct on width #56766

INDI/KStars on Raspberry Pi 4, 4gb
Raspbian Buster with AstroPi3 script configuration
Skywatcher HEQ5 Pro Mount
Canon 600D Camera
Orion SSAG/ASI120mm @280mm Guide Scope
PHD2
Adafruit Motor Hat shield
Adafruit GPS Module
Generic Bluetooth Joystick.
Startech 7 port powered USB Hub.

Please Log in or Create an account to join the conversation.

Time to create page: 0.667 seconds